refactor: Move calculating description, kind and label to CompletionValue #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue Previously, we would match on completion value in multiple places, which makes it hard to modify a behaviour for single type of completion. Now, I moved most logic into specific CompletionValue. There might be some additional things to refactor, but we can do it later on. Additionally, this fixes the added type in CaseKeyword completions.
tgodzik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would match on completion value in multiple places, which makes it hard to modify a behaviour for single type of completion. Now, I moved most logic into specific CompletionValue.
There might be some additional things to refactor, but we can do it later on.
Additionally, this fixes the added type in CaseKeyword completions, which was especially visible in the added test case.