fix: correctly import companion object for apply method #4567
Conversation
| val forImportSymbol = v match | ||
| case w: CompletionValue.Workspace => w.applyOwner | ||
| case _ => sym |
There was a problem hiding this comment.
Maybe it's enough to check it here? And not add a new field?
| val forImportSymbol = v match | |
| case w: CompletionValue.Workspace => w.applyOwner | |
| case _ => sym | |
| val forImportSymbol =if (v.symbol.isMethod) v.symbol.owner else v.symbol |
it would also work for expressions within string interpolation.
There was a problem hiding this comment.
Unfortunately we can't, because for example in ListBuffer(), owner of the apply method is trait IterableFactory. We have to somehow remember from which object this method came from
There was a problem hiding this comment.
I will see what we can do in case of string interpolation completions
There was a problem hiding this comment.
It seems suspicious that we are getting apply method symbols as Workspace completion.
In theory, workspace completion can be created only from a type or companion object symbol as they comes from classpath search.
There was a problem hiding this comment.
I think that was added by me when I added apply completions
| ) extends Symbolic: | ||
| override def isFromWorkspace: Boolean = true | ||
| val applyOwner: Symbol = maybeApplyOwner.getOrElse(symbol) |
There was a problem hiding this comment.
Maybe we could have importSymbol with a default of symbol and put it into the main Symbolic trait?
| |}""".stripMargin, | ||
| """|import scala.collection.mutable.ListBuffer | ||
| |object Main { | ||
| | val a = s"${ListBuffer($0)}"" |
There was a problem hiding this comment.
There is still an issue in case like
val a = s"$ListBuff@@"For now we don't provide apply completion there, because shouldAddSnippet flag is false in string interpolations (there is a problem with adding {}). I will work on that later
fixes #4066
Previously, when choosing apply method completion we would import incorrect symbol, now we import companion object.