Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add separate information about scripts #4643

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 16, 2022

We added some info in the previous release notes, but it's better to keep it in stable documentation.

I think we can start moving some feature docs to features tab to be easier to discover.

@tgodzik tgodzik changed the title docs: Add spearate information about scripts docs: Add separate information about scripts Nov 16, 2022
@LaurenceWarne
Copy link
Contributor

LaurenceWarne commented Nov 16, 2022

Nice! Suggestion: add a link to/something along thelines of https://scalameta.org/metals/docs/troubleshooting/faq/#how-do-i-use-scala-2xx-for-my-script, I think it can sometimes be easy to lookover it there: emacs-lsp/lsp-metals#78

docs/features/scripts.md Outdated Show resolved Hide resolved
docs/features/scripts.md Outdated Show resolved Hide resolved
docs/features/scripts.md Outdated Show resolved Hide resolved
docs/features/scripts.md Outdated Show resolved Hide resolved
We added some info in the previous release notes, but it's better to keep it in stable documentation.

I think we can start moving some feature docs to features tab to be easier to discover.
@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 25, 2022

Nice! Suggestion: add a link to/something along thelines of https://scalameta.org/metals/docs/troubleshooting/faq/#how-do-i-use-scala-2xx-for-my-script, I think it can sometimes be easy to lookover it there: emacs-lsp/lsp-metals#78

Added a link to the FAQ at the bottom.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha just a couple more ScalaCLI -> Scala CLI nits, but apart from that LGTM!

docs/features/scripts.md Outdated Show resolved Hide resolved
docs/features/scripts.md Outdated Show resolved Hide resolved
Co-authored-by: LaurenceWarne <17688577+LaurenceWarne@users.noreply.github.com>
Co-authored-by: Chris Kipp <ckipp@pm.me>
@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 25, 2022

Ha just a couple more ScalaCLI -> Scala CLI nits, but apart from that LGTM!

My eys were not successful in scanning the names 😅

@tgodzik tgodzik merged commit 88eef80 into scalameta:main Nov 25, 2022
@tgodzik tgodzik deleted the script-docs branch November 25, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants