chore: Deprecate and remove more Scala versions #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
deprecate-versions
branch
from
f624fb7
to
80e5f9e
Compare
ckipp01
approved these changes
Dec 10, 2022
| "2.13.3", | ||
| "2.13.4", | ||
| "2.13.5", | ||
| "2.13.6", | ||
| ) | ||
|
|
||
| def nonDeprecatedScala2Versions = Seq( |
There was a problem hiding this comment.
Maybe we should just come up with some random rule to follow like:
- Latest 3 versions are non deprecated
- Then another 2 are deprecated
So we'd then have support for 5 versions each, which to be honest should be enough. Since bumping from like 2.12.10 -> 2.12.whatever shouldn't be hard.
There was a problem hiding this comment.
That makes sense the 3 + 2 formula. Should we add it to the release procedure to check these? Or maybe remove after the release?
There was a problem hiding this comment.
Yea maybe after the release make sense.
ckipp01
added
tech debt
This should reduce the cross test times a bit and it's fine to deprecate and remove some older versions.
tgodzik
force-pushed
the
deprecate-versions
branch
from
80e5f9e
to
aa25613
Compare
|
Now that the release is out and this is all 🟢 I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the cross test times a bit and it's fine to deprecate and remove some older versions.