fix: correctly sort dependency completions #4804
Conversation
…mats Not all dependencies have version names in the same format, so previous way of sorting was causing exceptions. Now we use basic sorting on String as a fallback
jkciesluk
added
bug
| @@ -105,6 +105,17 @@ class CompletionScalaCliSuite extends BaseCompletionSuite { | |||
| "better-tostring", | |||
| ) | |||
|
|
|||
| checkEdit( | |||
| "alternative-sorting", | |||
| """|//> using lib "co.fs2::fs2-core:@@" | |||
There was a problem hiding this comment.
Out of curiosity, what was the format that was breaking sorting? Can we handle that in Version.fromString ?
There was a problem hiding this comment.
Side note: With some libraries like fs2 or cats-effect (can't remember for sure), scala-cli was suggesting an upgrade to sth like 3.3-commithashhere when 3.3.4 was the latest release. Could it be that sort of format?
(I'll report the issue in scala-cli when I see it again)
There was a problem hiding this comment.
Yes, it was caused by format like 3.5-ac5c657, but there are also versions like 3.2.14-75-7902cbf.
In Version we do
val parts = version.split("\\.|-")
val Array(major, minor, patch) = parts.take(3).map(_.toInt)Which fails trying to do toInt on commithash, so maybe we can handle it there somehow
There was a problem hiding this comment.
Potentially, we potentially drop any hash we encounter, since we can't get any semantic meaning from it.
Not all dependencies have version names in the same format, so previous way of sorting was causing exceptions. Now we use basic sorting on String as a fallback
fixes #4799