bugfix: Fix running when spaces are involved on windows #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Jan 5, 2023
| .replace("\\\"", "") | ||
| .replace("\"\\", "\\") | ||
| // when testing on Windows Program Files is problematic when splitting into list | ||
| .replace("Program Files", "ProgramFiles") |
There was a problem hiding this comment.
I am so very sorry about this :O
There was a problem hiding this comment.
The other option would be to find a process runner that takes in a whole string, but that seems even more work :/
Previously, we would not escape Java path, classpath or java properties, which meant that whenever spaces were involved things would not work on Windows (possibly on some other systems too). Now, we properly escape all those things. I tested both by hand and added a test case, which proved to be a pain to write :/ Fixes scalameta#4801
tgodzik
force-pushed
the
fix-running-windows
branch
from
3908c2b
to
468bb97
Compare
ckipp01
approved these changes
Jan 5, 2023
metals/src/main/scala/scala/meta/internal/metals/debug/ExtendedScalaMainClass.scala
Outdated
Show resolved
Hide resolved
| .replace("\\\"", "") | ||
| .replace("\"\\", "\\") | ||
| // when testing on Windows Program Files is problematic when splitting into list | ||
| .replace("Program Files", "ProgramFiles") |
…dScalaMainClass.scala Co-authored-by: Chris Kipp <ckipp@pm.me>
|
It's really fantastic to see Windows issues being handled so quickly 👏 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would not escape Java path, classpath or java properties, which meant that whenever spaces were involved things would not work on Windows (possibly on some other systems too). Now, we properly escape all those things.
I tested both by hand and added a test case, which proved to be a pain to write :/
Fixes #4801