Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure doctor reports that diagnostics in sbt targets work #4842

Merged
merged 1 commit into from Jan 12, 2023
Merged

fix: ensure doctor reports that diagnostics in sbt targets work #4842

merged 1 commit into from Jan 12, 2023

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jan 11, 2023

Fixes: #4781

@ckipp01 ckipp01 requested a review from tgodzik January 11, 2023 12:19
tgodzik
tgodzik approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckipp01 ckipp01 merged commit a3c3877 into scalameta:main Jan 12, 2023
@ckipp01 ckipp01 deleted the sbtDiagnostics branch January 12, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect message about sbt build diagnostics when using sbt as a build server
2 participants
@ckipp01 @tgodzik