Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adding wrapper for metals server configuration #4845

Merged
merged 2 commits into from Jan 13, 2023
Merged

refactor: adding wrapper for metals server configuration #4845

merged 2 commits into from Jan 13, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jan 11, 2023 •
edited

Context: A number of parameters must passed to MetalsLanguageServer and MetalsLspService to allow for custom behaviour needed for testing.

Previously: All those parameters were passed as arguments to both MetalsLanguageServer and MetalsLspService constructors.
Now: The arguments are wrapped in a configuration class.

closes #4789

@kasiaMarek kasiaMarek closed this Jan 11, 2023
@kasiaMarek kasiaMarek reopened this Jan 11, 2023
@kasiaMarek kasiaMarek marked this pull request as ready for review January 11, 2023 16:59
kpodsiad
kpodsiad requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great jobs with documenting all of those parameters, surely @ckipp01 will be in seventh heaven while seeing this :D

metals/src/main/scala/scala/meta/internal/metals/MetalsServerConfiguration.scala Outdated Show resolved Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsServerConfiguration.scala Outdated Show resolved Hide resolved
tgodzik
tgodzik requested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I am not sure about the name inputs, but I can't think of anything better.

metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala Outdated Show resolved Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala Outdated Show resolved Hide resolved
kpodsiad
kpodsiad approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🚀

tgodzik
tgodzik approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tgodzik tgodzik merged commit e0fe763 into scalameta:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@kpodsiad kpodsiad kpodsiad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean constructor parameters in MetalsLanguageServer and MetalsLanguageService
3 participants
@kasiaMarek @tgodzik @kpodsiad