feature: Add semantic tokens for sbt and script files #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
script-sbt-semantic
branch
from
eb05973
to
ba0a7b6
Compare
jkciesluk
reviewed
Jan 13, 2023
metals/src/main/scala/scala/meta/internal/metals/Compilers.scala
Outdated
Show resolved
Hide resolved
tgodzik
force-pushed
the
script-sbt-semantic
branch
2 times, most recently
from
05a3bfd
to
2223156
Compare
Previously, semantic tokens would not work for files ending with `.sc` or `.sbt`. Now they properly work with correct types inferred by the compiler. Main parts were: - discarding any tokens that were added to the file, this required making sure that adjust position would return lines < 0, so that we can recognize those tokens - make sure that the first token had the correct deltas - worksheets need to have semantic tokens refreshed after downloading all dependencies etc. - added tests for all the possibilities including Ammonite scripts, worksheets, sbt files within sbt BSP and Bloop
tgodzik
force-pushed
the
script-sbt-semantic
branch
from
2223156
to
78dacb3
Compare
jkciesluk
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, semantic tokens would not work for files ending with
.scor.sbt. Now they properly work with correct types inferred by the compiler.Main parts were: