fix: correctly insert type annotation in tuples lambda args #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ```scala List((1,2)).map((<<a>>,b) => a) // would insert type here List((1,2)).map((a,b) => a: Int) ``` This happened because tuple argument symbols don't have `Param` flag (probably connected to scala/scala3#16110) Now we have different way to check if we are on parameter
jkciesluk
commented
Jan 13, 2023
| @@ -236,7 +241,10 @@ final class InferredTypeProvider( | |||
| */ | |||
| case Some(df @ DefDef(name, _, tpt, rhs)) => | |||
| def typeNameEdit = | |||
| val end = tpt.endPos.toLsp | |||
| val end = | |||
There was a problem hiding this comment.
In scala 3.1.3,
List((1,2)).map((<<a>>,b) => ...) //results in
List((1,2)).map((:Inta,b) => ...)a and b are treated as methods, but their tpt.SourcePos == df.namePos.startPos, so we need this correctly insert type after name
tgodzik
requested changes
Jan 14, 2023
mtags/src/main/scala-3/scala/meta/internal/pc/InferredTypeProvider.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4849
Previously
This happened because tuple argument symbols don't have
Paramflag (probably connected to scala/scala3#16110) Now we have different way to check if we are on parameter