Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Remove check for stacktrace markers #4947

Merged
merged 1 commit into from Feb 7, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Feb 7, 2023

There is no need to check for any specific markers, we should just try our best to find a symbol.

For example:

[T] java.nio.file.FileSystemException:/Users/kpodsiadlo/.../.bloop/common/bloop-bsp-clients-classes/classes-bloop-cli-vSjz_SG8RNKglt17I28D_A==/com/evolution/.../data/macros/WeightsMacros.class: Invalid argument
[T]     java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:100)
[T]     java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
[T]     java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
[T]     java.base/sun.nio.fs.UnixCopyFile.copyFile(UnixCopyFile.java:246)
[T]     java.base/sun.nio.fs.UnixCopyFile.copy(UnixCopyFile.java:603)
[T]     java.base/sun.nio.fs.UnixFileSystemProvider.copy(UnixFileSystemProvider.java:257)
[T]     java.base/java.nio.file.Files.copy(Files.java:1305)
[T]     bloop.io.ParallelOps$.copy$1(ParallelOps.scala:161)
[T]     bloop.io.ParallelOps$.$anonfun$copyDirectories$8(ParallelOps.scala:194)
[T]     scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[T]     monix.eval.internal.TaskRunLoop$.startFuture(TaskRunLoop.scala:494)
[T]     monix.eval.Task.runToFutureOpt(Task.scala:586)
[T]     monix.eval.internal.TaskDeprecated$Extensions.runSyncMaybeOptPrv(TaskDeprecated.scala:128)
[T]     monix.eval.internal.TaskDeprecated$Extensions.$anonfun$coeval$1(TaskDeprecated.scala:303)
[T]     monix.eval.Coeval$Always.apply(Coeval.scala:1451)
[T]     monix.eval.Coeval.value(Coeval.scala:258)
[T]     bloop.io.ParallelOps$.$anonfun$copyDirectories$7(ParallelOps.scala:220)
[T]     monix.reactive.internal.consumers.ForeachAsyncConsumer$$anon$1.onNext(ForeachAsyncConsumer.scala:44)
[T]     monix.reactive.internal.consumers.LoadBalanceConsumer$$anon$1.$anonfun$signalNext$1(LoadBalanceConsumer.scala:218)
[T]     monix.execution.internal.InterceptRunnable.run(InterceptRunnable.scala:27)
[T]     java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[T]     java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[T]     java.base/java.lang.Thread.run(Thread.java:833)

@tgodzik tgodzik requested a review from kpodsiad February 7, 2023 12:55
@tgodzik tgodzik merged commit 2be8450 into scalameta:main Feb 7, 2023
@tgodzik tgodzik deleted the removed-unneccessary branch February 7, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants