improvement: Remove scalameta parsing in InferredTypeProvider #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would use scalameta parser to correctly insert type in some places. Now, we removed it to enable easier migration of the module to scala3-compiler
tgodzik
commented
Feb 8, 2023
| @@ -203,20 +203,6 @@ final class InferredTypeProvider( | |||
| def simpleType = | |||
| typeNameEdit ::: imports | |||
|
|
|||
| def tupleType(applied: AppliedType) = | |||
There was a problem hiding this comment.
Looks like this was needed for some earlier versions.
rochala
added a commit
to rochala/metals
that referenced
this pull request
Feb 20, 2023
tgodzik
pushed a commit
that referenced
this pull request
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would use scalameta parser to correctly insert type in some places. Now, we removed it to enable easier migration of the module to scala3-compiler