bugfix: Fix issues with auto imports not showing up #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Feb 9, 2023
| @@ -40,8 +38,9 @@ class ImportMissingSymbol(compilers: Compilers, buildTargets: BuildTargets) | |||
| codeAction | |||
| .getEdit() | |||
| .getChanges() | |||
| .getOrDefault(uri, Collections.emptyList) | |||
There was a problem hiding this comment.
This is another one :/
Changes would have file:///C:/Users/Tomasz/Documents/Work/CodeActionImportIssue/subprojecta/src/main/scala/SomeClassA.scala
while uri was "file:///c%3A/Users/Tomasz/Documents/Work/CodeActionImportIssue/subprojecta/src/main/scala/SomeClassA.scala
ckipp01
reviewed
Feb 9, 2023
tgodzik
force-pushed
the
fix-windows-escaping
branch
from
d14bd99
to
df320fe
Compare
Previously, we merging different auto imports into one, we would us uri to get the changes from the single action. That uri might have been encoded/decode which might be different from what there is in a map of changes. Now, instead we just merge all the changes to avoid any issues with url decoding or encoding. Those changes cannot come from different files, so this will not be an issue. Fixes scalameta#4906
|
I had a bit of a weird issue with this PR, but it's rebased and running now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we merging different auto imports into one, we would us uri to get the changes from the single action. That uri might have been encoded/decode which might be different from what there is in a map of changes.
Now, instead we just merge all the changes to avoid any issues with url decoding or encoding. Those changes cannot come from different files, so this will not be an issue.
Fixes #4906