bugfix: Fix completion tests and make them more stable #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
approved these changes
Feb 9, 2023
New circe version got release, which made the tests fail, so instead I will test completion on an earlier version
tgodzik
commented
Feb 9, 2023
| @@ -40,10 +40,10 @@ class CompletionScalaCliSuite extends BaseCompletionSuite { | |||
|
|
|||
| check( | |||
| "version", | |||
| """|//> using lib "io.circe::circe-core_native0.4:@@" | |||
| """|//> using lib "io.circe::circe-core_sjs1:0.14.1@@" | |||
There was a problem hiding this comment.
There is no js version for 0.13 so instead I put in a full version. Next should be 0.15 so we should safe here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New circe version got release, which made the tests fail, so instead I will test completion on an earlier version