bugfix: Don't collect symbols from Inline expansion #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Metals would have a hanging thread when for example in github.com:Atry/scalajs-all-in-one-template. Now, it doesn't end up in an infinite loop. I haven't been able to find a proper test for it aside from the very complex example with macros, but we shouldn't need to traverse expansion as it's the tree that is not in the original code.
kasiaMarek
approved these changes
Feb 21, 2023
jkciesluk
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Metals would have a hanging thread when for example in github.com:Atry/scalajs-all-in-one-template. Now, it doesn't end up in an infinite loop.
I haven't been able to find a proper test for it aside from the very complex example with macros, but we shouldn't need to traverse expansion as it's the tree that is not in the original code.
Fixes #4987