Keep exception cause in some mtags exceptions #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the cause exception to the Exception contructor makes it easier for users to know what's going on: the JVM or the printStackTrace method will print the current exception and its cause (and the cause's cause, etc.). That way, we know in more detail what the underlying cause of the exception is.
alexarchambault
force-pushed
the
keep-exception-cause
branch
from
cf40684
to
c7f7404
Compare
jkciesluk
pushed a commit
to jkciesluk/metals
that referenced
this pull request
May 19, 2023
Passing the cause exception to the Exception contructor makes it easier for users to know what's going on: the JVM or the printStackTrace method will print the current exception and its cause (and the cause's cause, etc.). That way, we know in more detail what the underlying cause of the exception is.
jkciesluk
pushed a commit
to jkciesluk/metals
that referenced
this pull request
May 19, 2023
Passing the cause exception to the Exception contructor makes it easier for users to know what's going on: the JVM or the printStackTrace method will print the current exception and its cause (and the cause's cause, etc.). That way, we know in more detail what the underlying cause of the exception is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the cause exception to the
Exceptioncontructor makes it easier for users to know what's going on: the JVM or theprintStackTracemethod will print the current exception and its cause (and the cause's cause, etc.). That way, we know in more detail what the underlying cause of the exception is.