buigfix: given scala toplevel mtags #5247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
requested changes
May 19, 2023
| |given [T]: List[T] = Nil | ||
| |given given_Char: Char = '?' | ||
| |given `given_Float`: Float = 3.0 | ||
| |given `* *` : Long = 5 |
There was a problem hiding this comment.
Suggested change
| |given `* *` : Long = 5 | |
| |given `* *`: Long = 5 |
I was confused why * * didn't show in result, but it was because of a whitespace.
There was a problem hiding this comment.
Oh, you're so right. I forgot that also turns into a token. Thanks for noticing.
| consumeParams() | ||
| scanner.curr.token match { | ||
| case COLON => identifier | ||
| case _ => None |
There was a problem hiding this comment.
It will fail if there is a whitespace before COLON
kasiaMarek
force-pushed
the
given-scala-toplevel-mtags
branch
from
8efec56
to
c4cf7df
Compare
kasiaMarek
force-pushed
the
given-scala-toplevel-mtags
branch
from
c4cf7df
to
1a3ae52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
In ScalatopLevelMtags we expected an identifier after
givenkeyword, so we would fail ongiven [A]....Now:
ScalatopLevelMtagson an error, instead we create a report and keep indexing.