fix: Don't show completions with case class members #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
reviewed
Jun 13, 2023
| @@ -578,6 +578,7 @@ class Completions( | |||
| indexedContext.lookupSym(sym) match | |||
| case IndexedContext.Result.InScope => | |||
| visit(CompletionValue.scope(sym.decodedName, sym)) | |||
| case _ if sym.maybeOwner.is(Flags.CaseClass) => true | |||
There was a problem hiding this comment.
It doesn't make sense for any class not just case class but never happens for anything else, I am understanding it right?
There was a problem hiding this comment.
Turns out it happens more ofter. We are indexing also members of case class/class/trait etc. but we don't filter them out for completions, and they can't be brought to scope via import. I changed isAccessible, which should solve this issue
jkciesluk
force-pushed
the
i5289
branch
3 times, most recently
from
b4b80b5
to
e5e7afd
Compare
jkciesluk
commented
Jun 20, 2023
| @@ -394,7 +394,6 @@ class CompletionSnippetSuite extends BaseCompletionSuite { | |||
| "3" -> | |||
| """|Try | |||
| |Try($0) | |||
| |TryMethods | |||
There was a problem hiding this comment.
I believe this completion was incorrect, since it a member of a trait?
kasiaMarek
requested changes
Jun 22, 2023
mtags/src/main/scala-3/scala/meta/internal/pc/CompilerSearchVisitor.scala
Outdated
Show resolved
Hide resolved
kasiaMarek
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't think of any other case when we don't want to see case class members, so it was easier to change it directly in completions, instead of changing
includeMembersinScalaToplevelMtagssolves #5289