Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update lihaoyi's and scalameta dependencies #5425

Merged
merged 1 commit into from Jul 11, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jul 11, 2023

Thanks to shading added to scalameta we can now update the dependencies.

Thanks @kitbellew !

Thanks to shading added to scalameta we can now update the dependencies.
Copy link

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also update scalafmt 🙂

@tgodzik tgodzik merged commit de5c883 into scalameta:main Jul 11, 2023
22 of 24 checks passed
@tgodzik tgodzik deleted the update-lihaoyi branch July 11, 2023 13:48
@tgodzik
Copy link
Contributor Author

tgodzik commented Jul 11, 2023

Actually, we're getting an error for:

    def collectCompletions(
        isWorkspace: Boolean
    ): PartialFunction[Symbol, List[CompletionValue]] =
      case sym
          if CompletionFuzzy.matches(
            interpolator.name,
            sym.name.decoded,
          ) && !sym.isType =>
        val label = sym.name.decoded
        completions.completionsWithSuffix(
          sym,
          label,
          (name, s, suffix) =>
            CompletionValue.Interpolator(
              s,
              label,
              Some(newText(name, suffix.toEditOpt)),
              additionalEdits(),
              Some(nameRange),
              None,
              sym,
              isWorkspace,
            ),
        )
    end collectCompletions

wasn't that specific case fixed actually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants