Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: monitor build server liveness #5462

Merged
merged 1 commit into from Aug 3, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jul 18, 2023

Ping the server every minute and if it sends no response/sends no notifications in two minutes inform the user that it may need to be restarted.

@kasiaMarek kasiaMarek force-pushed the build-server-liveness branch 2 times, most recently from 6d0c541 to beaedbd Compare July 19, 2023 15:12
@kasiaMarek kasiaMarek marked this pull request as ready for review July 20, 2023 08:15
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few changes from me

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's try it in action

@tgodzik tgodzik merged commit 3639477 into scalameta:main Aug 3, 2023
23 checks passed
@jkciesluk jkciesluk modified the milestone: Metals v1.0.1 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants