New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: monitor build server liveness #5462
Conversation
6d0c541
to
beaedbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few changes from me
metals/src/main/scala/scala/meta/internal/metals/ServerLivenessMonitor.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/ServerLivenessMonitor.scala
Outdated
Show resolved
Hide resolved
beaedbd
to
fd91e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's try it in action
Ping the server every minute and if it sends no response/sends no notifications in two minutes inform the user that it may need to be restarted.