Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Don't show semantic tokens warning for Java files #5463

Merged
merged 1 commit into from Jul 20, 2023
Merged

chore: Don't show semantic tokens warning for Java files #5463

merged 1 commit into from Jul 20, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jul 19, 2023

No description provided.

@tgodzik tgodzik requested a review from jkciesluk July 19, 2023 11:16
@jkciesluk
Copy link
Member

Actually, maybe we can return empty tokens already in Compilers.semanticTokens, even without loading the compiler?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jul 19, 2023

Actually, maybe we can return empty tokens already in Compilers.semanticTokens, even without loading the compiler?

I just figured that if someone actually adds Java support it's one less place they need to fix things.

@jkciesluk
Copy link
Member

jkciesluk commented Jul 19, 2023 •
edited

I just figured that if someone actually adds Java support it's one less place they need to fix things.

Sure, good idea

@tgodzik tgodzik merged commit 7f86f32 into scalameta:main Jul 20, 2023
21 of 23 checks passed
@tgodzik tgodzik deleted the warning-java branch July 20, 2023 17:55
@jkciesluk jkciesluk modified the milestone: Metals v1.0.1 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkciesluk jkciesluk jkciesluk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgodzik @jkciesluk