Scala2 - deduplicate NamedArgParams with Def params #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedArgParam is based on actual symbol, in the following case the valid symbol `param` and correspoding NamedArgParam(`param`) were clashing
```
def foo(param: Int): Int = {
foo(para@@)
}
```
dos65
commented
Jul 20, 2023
| @@ -23,14 +23,14 @@ class CompletionArgSuite extends BaseCompletionSuite { | |||
| check( | |||
| "arg-newline", | |||
| s"""|object Main { | |||
| | def foo(banana: String, apple: String) = ??? | |||
| | def foo(banana: String, tomato: String) = ??? | |||
There was a problem hiding this comment.
After making a deduplication, this tests started receiving an additional apple package symbol from jdk so I decided just to rename it
kasiaMarek
approved these changes
Jul 20, 2023
tgodzik
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedArgParam is based on actual symbol, in the following case the valid symbol
paramand correspoding NamedArgParam(param) were clashing