fix: InverseSemanticdbSymbols for symbolic names #5481
Conversation
|
What about package names? Do you not need to encode those too? |
| ) | ||
| _ <- assertCompletionItemResolve( | ||
| "val x: !!@@", | ||
| expectedLabel = "!!", |
There was a problem hiding this comment.
Question (sorry if doesn't make sense, just caught my attention): for the ::: from Scala's List above we get label with much more info (generic type signature, return type, etc.), but here for the !! we only see the symbol name. Is it expected? 🙂
There was a problem hiding this comment.
This is a valid question. Basically, for type completions, this information is not a part of label, but is provided in detail (in vscode its in the same place as doc)
Thanks for noticing! Yes, although it looks like docstrings aren’t attached to packages (not sure yet why), but it's not connected to this PR. I added encoding there, so it will be easier to fix in the future |
Yes, in scala 3 symbol names are kept in decoded form |
Symbols in compiler have encoded names (eg. `$at$at` instead of `@@`) so we need to encode semanticdb symbols before matching on name.
Symbols in compiler have encoded names (eg.
$at$atinstead of@@) so we need to encode semanticdb symbols before matching on name.Fixes #5469 and #5065