Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: port extension-methods-complex test fix from dotty #5542

Merged
merged 1 commit into from Aug 10, 2023
Merged

chore: port extension-methods-complex test fix from dotty #5542

merged 1 commit into from Aug 10, 2023

Conversation

kasiaMarek
Copy link
Contributor

fix HoverScala3TypeSuite.extension-methods-complex test after scala/scala3@d521be5

@kasiaMarek
chore: port extension-methods-complex test fix from dotty
09a452f 
fix `HoverScala3TypeSuite.extension-methods-complex` test after
scala/scala3@d521be5
tgodzik
tgodzik approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I asked why the test actually changed in the compiler, since it's not clear for me, but this is a great find, thanks!

@kasiaMarek
Copy link
Contributor Author

kasiaMarek commented Aug 10, 2023 •
edited

I asked why the test actually changed in the compiler, since it's not clear for me

I don't know what changed but this wasn't a valid piece of code.

@tgodzik
Copy link
Contributor

tgodzik commented Aug 10, 2023

I asked why the test actually changed in the compiler, since it's not clear for me

I don't know what changed but this wasn't a valid piece of code.

Och interesting, I didn't realize that.

@tgodzik tgodzik merged commit 9cdafca into scalameta:main Aug 10, 2023
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasiaMarek @tgodzik