improvement: Automatically calculate last supported versions for semanticdb #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
tgodzik
force-pushed
the
automatically-resolve-semanticdb
branch
from
c75d8f7
to
5c088de
Compare
tgodzik
force-pushed
the
automatically-resolve-semanticdb
branch
from
5c088de
to
b7d90af
Compare
jkciesluk
reviewed
Sep 25, 2023
| scalaVersion | ||
| ) | ||
| s"org.scalameta:::semanticdb-scalac:$semanticdbVersion" :: compilerPlugins.toList | ||
| } else compilerPlugins.toList |
There was a problem hiding this comment.
Why we don't want to have semanticdb plugin for Scala 3 here?
There was a problem hiding this comment.
We don't have it as a plugin, it's in the compiler, so no need to download anything.
…nticdb Previously, we would fail if our version of semanticdb was not supported for a sepcific scala version. Now, we calculate last supported version for each scala version when compiling. Potentially this means we could get a new semanticdb version automatically, but that should not be an issue as semanticdb is well tested in scalameta itself
tgodzik
force-pushed
the
automatically-resolve-semanticdb
branch
from
b7d90af
to
835ab98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would fail if our version of semanticdb was not supported for a specific scala version. Now, we calculate last supported version for each scala version when compiling.
Potentially this means we could get a new semanticdb version automatically, but that should not be an issue as semanticdb is well tested in scalameta itself
This is needed for the sbt-metals plugin