bugfix: escape special chars in test names #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
dap-special-chars
branch
from
31f7382
to
4a8058e
Compare
tgodzik
reviewed
Sep 27, 2023
metals/src/main/scala/scala/meta/internal/metals/debug/DebugProvider.scala
Outdated
Show resolved
Hide resolved
kasiaMarek
force-pushed
the
dap-special-chars
branch
from
4a8058e
to
d76850c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5670
Still having "(" won't work but that needs an upstream fix. I still left "(" in special characters since now it just incorrectly ignores the test and before it would fail on creating a regex pattern.