bugfix: match completions for type aliases scala 3 #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
added
Scala 3
filipwiech
reviewed
Oct 5, 2023
| @@ -734,4 +734,52 @@ class CompletionMatchSuite extends BaseCompletionSuite { | |||
| filter = _.contains("exhaustive"), | |||
| ) | |||
|
|
|||
| checkEdit( | |||
There was a problem hiding this comment.
These cases already seem to work for Scala 2 (with Animal being sealed type hierarchy instead of enum). Would it be worth it to add unit tests for it as well (or maybe there are already some)? 🙂
jkciesluk
requested changes
Oct 5, 2023
There was a problem hiding this comment.
For case completions I think you need to change it also here https://github.com/scalameta/metals/pull/5714/files#diff-8cca6f591058d93dae851ed5830ec69c9172cb020410921fe8dddff10d3d8e9eR153
filipwiech
approved these changes
Oct 7, 2023
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Oct 9, 2023
metals backport: scalameta/metals#5714 CC: @tgodzik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5712