bugfix: Completions for named args in wrong order #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Oct 10, 2023
kasiaMarek
reviewed
Oct 10, 2023
Comment on lines
+74
to
+84
| NavigateAST.untypedPath(pos.span) match | ||
| case (ident: Ident) :: (app: Apply) :: _ => |
There was a problem hiding this comment.
Do you need the untyped tree, because if the first arg is named Ident isn't there? Is this part totally missing from the typed tree then? Is that why you're passing the untyped Apply?
jkciesluk
force-pushed
the
named-wrong-order
branch
2 times, most recently
from
012d9c0
to
27454f7
Compare
rochala
pushed a commit
to scala/scala3
that referenced
this pull request
Nov 10, 2023
jkciesluk
force-pushed
the
named-wrong-order
branch
from
27454f7
to
ca00cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have
we want to get
aaacompletion