Insert local import when completing workspace symbol. #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Metals inserted a fully qualified name at the completion position. With this commit, we now insert a local import in the nearest enclosing block. Down the road, we can add a code action to "Move import to global scope" to clean up local imports inserted by Metals. Other improvements in this commit: - we render the package name in the completion item label so that it's more visible what you are importing. - we no longer use insert text, which is a deprected LSP feature and has unclear semantics between editors. Instead, we only use `textEdit`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Metals inserted a fully qualified name at the completion
position. With this commit, we now insert a local import in the nearest
enclosing block. Down the road, we can add a code action to "Move import
to global scope" to clean up local imports inserted by Metals.
Other improvements in this commit:
more visible what you are importing.
has unclear semantics between editors. Instead, we only use
textEdit.