bugfix: Show properly completions for higher order functions #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Scala 2 would not show anything when at `f(_.@@)` and f had more than one parameter. The completions from the compiler would be empty. Now, we retry with a coma in that case. Scala 3 was working properly. Fixes scalameta#5836
jkciesluk
requested changes
Nov 16, 2023
There was a problem hiding this comment.
It doesn't work if the method has more than one parameter after the one with function
def foo(arg1: Int => String, arg2: Int, arg3: Int) = ???
val bar = foo(_.@) // nothing shows up Maybe we should check amount of parameters and insert that many commas?
Also, in this case there are no completions in
val bar = foo(_.@, , )
// but we get completions in
val bar = foo(_.@, _, )So maybe we should insert _ (or anything actually) in every missing parameter?
|
Looks like we need to fix it in the compiler :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Scala 2 would not show anything when at
f(_.@@)and f had more than one parameter. The completions from the compiler would be empty.Now, we retry with a coma in that case.
Scala 3 was working properly.
Fixes #5836