chore: upgrade h2 database #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That seems to be a good ide 👍 |
kasiaMarek
force-pushed
the
upgrade-h2
branch
from
5d747bf
to
5ff40a2
Compare
tgodzik
approved these changes
Dec 6, 2023
| private def upgradeIfNeeded(url: String): Unit = { | ||
| val oldVersion = 214 | ||
| val formatVersionChangedMessage = | ||
| "The write format 2 is smaller than the supported format 3" |
There was a problem hiding this comment.
Any chance we can match on an exact error?
There was a problem hiding this comment.
We could not check the exact message and just the error code. Trouble is that we wouldn't know the versions are2 and 3, so if it changes again in the future, it might be 3 and 4. Maybe it doesn't matter so much since it will fail if the versions change again anyway. Otherwise (looking at the source code), the versions in the error are only in the message I'm afraid.
jkciesluk
reviewed
Dec 7, 2023
| registerNiceToHaveFilePatterns() | ||
| tables.connect() |
There was a problem hiding this comment.
loadFingerPrints() has to do tables.connect() anyway. It's just a duplication really.
jkciesluk
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5447
Do we want to fallback to deleting the db if this mechanism fails?