Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: log when invalid textDocument uri in build/publishDignostics #5950

Merged
merged 1 commit into from Dec 18, 2023
Merged

improvement: log when invalid textDocument uri in build/publishDignostics #5950

merged 1 commit into from Dec 18, 2023

Conversation

kasiaMarek
Copy link
Contributor

Connected to: #4814

Honestly not sure if that makes it much better.

tgodzik
tgodzik approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will at least show the diagnostic even if we can't find the files to attach it to.

@kasiaMarek kasiaMarek merged commit 72692d2 into scalameta:main Dec 18, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasiaMarek @tgodzik