Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix java support for different files #5964

Merged
merged 1 commit into from Dec 21, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Dec 20, 2023

Previously, we wouldn't include the classpath, so completions/hover would only work locally.

Now, we add the compiled classpath, so things should work as expected.

Fixes #5829

Previously, we wouldn't include the classpath, so completions/hover would only work locally.

Now, we add the compiled classpath, so things should work as expected.

Fixes scalameta#5829
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit a7f95d7 into scalameta:main Dec 21, 2023
25 checks passed
@tgodzik tgodzik deleted the fix-java branch December 21, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completions invoked from java files only work for stdlib types
2 participants