chore: Unignore tests after backporting #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ach, I think because I broke master, we didn't get a new nightly last night. |
tgodzik
commented
Jan 13, 2024
| "3.3.2" -> """|using (commit: '') | ||
| |unsafeExceptions scala (commit: '') | ||
| |unchecked scala (commit: '') | ||
| |unsafe - caps (commit: '') |
There was a problem hiding this comment.
Suggested change
| |unsafe - caps (commit: '') | |
| |unsafe - caps (commit: '') |
Scala is not printed here, there is a specific logic in the printer that is hard to make work and is working fine with the presentation compiler module itselg.
tgodzik
commented
Jan 13, 2024
| @@ -568,7 +564,7 @@ class SyntheticDecorationsSuite extends BaseSyntheticDecorationsSuite { | |||
| ) | |||
|
|
|||
| check( | |||
| "val-def-with-bind", | |||
| "val-def-with-bind".tag(IgnoreForScala3CompilerPC), | |||
There was a problem hiding this comment.
@jkciesluk didn't you fix this, maybe it wasn't backported?
There was a problem hiding this comment.
It was fixed in #5891, we probably didn't backport it
jkciesluk
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.