Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Change BSP ping message to empty buildtarget/compile #6058

Merged
merged 1 commit into from Jan 30, 2024

Conversation

jkciesluk
Copy link
Member

workspace/buildTargets was causing unnecessary operations in bazelbsp. This new method should be faster and doesn't require any actions from the build server

@tgodzik
Copy link
Contributor

tgodzik commented Jan 29, 2024

Did you make sure it works with all the current build servers? sbt, 'mill' and bloop ?

@jkciesluk
Copy link
Member Author

Did you make sure it works with all the current build servers? sbt, 'mill' and bloop ?

It works fine with sbt, mill and bazel but bloop reports an error "Empty build targets. Expected at least one build target identifier." Maybe its something we can change in bloop?

@tgodzik
Copy link
Contributor

tgodzik commented Jan 29, 2024

Did you make sure it works with all the current build servers? sbt, 'mill' and bloop ?

It works fine with sbt, mill and bazel but bloop reports an error "Empty build targets. Expected at least one build target identifier." Maybe its something we can change in bloop?

For now we could use the current ping for Bloop I think, later we would anyway want to check the version to use the correct ping. Using empty compile might be better in the long run.

`workspace/buildTargets` was causing unnecessary operations in bazelbsp.
This new method should be faster and doesn't require any actions from the build server
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 3690c9b into scalameta:main Jan 30, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants