Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: use text document version for initial package edit #6128

Merged
merged 1 commit into from Feb 19, 2024
Merged

bugfix: use text document version for initial package edit #6128

merged 1 commit into from Feb 19, 2024

Conversation

kasiaMarek
Copy link
Contributor

resolves: #2869

It turns out, that VSCode is able to deal with this if only metals supports text document version.

@kasiaMarek kasiaMarek marked this pull request as ready for review February 16, 2024 10:25
tgodzik
tgodzik approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O wow, good find! I wasn't aware of this.

I suppose using versioned identifier everywhere would be much better, maybe it would some other weird things people were noticing.

There is an issue about it FYI #1665

@kasiaMarek kasiaMarek merged commit 7118d59 into scalameta:main Feb 19, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"save as" duplicates packages
2 participants
@kasiaMarek @tgodzik