improvement: Add fallback for inlay hints #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Scala 3.nightly, it maps old synthetic decorations to inlay hints. Its needed because inlay hints are not available for every Scala version
jkciesluk
force-pushed
the
inlay-hints-fallback
branch
from
c217f82
to
3975723
Compare
tgodzik
reviewed
Feb 23, 2024
| ScalaVersions.isSupportedAtReleaseMomentScalaVersion(version) | ||
| default.resolve(scalaVersion).orElse { | ||
| if (ScalaVersions.isSupportedAtReleaseMomentScalaVersion(scalaVersion)) | ||
| Some(MtagsBinaries.BuildIn) |
There was a problem hiding this comment.
Would this not resolve always latest Scala 2.13 mtags?
There was a problem hiding this comment.
Only if resolve failed and we want to use supported Scala version. I think its used only in unit tests, where we don't publish mtags
tgodzik
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Scala 3.nightly, it maps old synthetic decorations to inlay hints. Its needed because inlay hints are not available for every Scala version