improvement: Show semanticdb missing when using Bazel #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
approved these changes
Feb 21, 2024
jkciesluk
approved these changes
Feb 21, 2024
metals/src/main/scala/scala/meta/internal/metals/ScalaTarget.scala
Outdated
Show resolved
Hide resolved
Currently, it's not possible to get information from Bazel BSP if it produces semanticdb files. Instead, we now assume that Bazel needs to support it itself and only later check if that is really the case. Additional bonus here is that all other tools will benefit from this change with the added information on whether semanticdb files were actually produced. Fixes scalameta#6130
tgodzik
force-pushed
the
fix-wrong-message
branch
from
f663239
to
857a7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to get information from Bazel BSP if it produces semanticdb files.
Instead, we now assume that Bazel needs to support it itself and only later check if that is really the case. Additional bonus here is that all other tools will benefit from this change with the added information on whether semanticdb files were actually produced.
Fixes #6130