Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: allow for mixed multiple custom and known build servers #6273

Merged
merged 1 commit into from Apr 4, 2024
Merged

bugfix: allow for mixed multiple custom and known build servers #6273

merged 1 commit into from Apr 4, 2024

Conversation

kasiaMarek
Copy link
Contributor

resolves: #6261

This resolves two issues:

  1. fixes connecting to custom bsp in presence of multiple bsp configs and a known build tool (e.g. sbt) in workspace
  2. allows for <name>.json to differ from "name" in bsp config

@kasiaMarek kasiaMarek requested a review from tgodzik April 3, 2024 07:36
tgodzik
tgodzik approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasiaMarek kasiaMarek merged commit 3d3bc12 into scalameta:main Apr 4, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto connection for custom BSP doesn't work
2 participants
@kasiaMarek @tgodzik