feat: Set unused tag for unused diagnostics #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostbuster91
force-pushed
the
unused-diag
branch
from
8df9cda
to
aa847a6
Compare
ghostbuster91
commented
May 30, 2024
| object DiagnosticCodes { | ||
| val Unused: Int = 198 | ||
|
|
||
| def isEqual(lspCode: Either[String, Integer], other: Int): Boolean = { |
There was a problem hiding this comment.
thought: I didn't find any additional info when it can be one or the other and if both should be treated as diagnostic codes.
The spec says:
/**
* The diagnostic's code, which might appear in the user interface.
*/
code?: [integer](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#integer) | string;
rochala
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for: scala/scala3#19780For now this will only work for scala3 as scala2 does not emit errorCodes.
Regex based support for this feature in scala2 will be added as a follow-up.
cc @rochala