Generate exhaustive pattern match for sealed types. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, you had to write on case at a time when pattern matching on a sealed type. Now, you can complete on the `match` keyword and select the "match (exhaustive)" completion item to generate all cases. This commit also introduces a new "match" completion (non-exhaustive) that generates a single case and triggers a new completion at the case word, for editors that support `CompletionItem.command`.
The `knownDirectSubClasses` method works less reliably in 2.11 compared to 2.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630.
Previously, you had to write on case at a time when pattern matching on
a sealed type. Now, you can complete on the
matchkeyword and selectthe "match (exhaustive)" completion item to generate all cases. This
commit also introduces a new "match" completion (non-exhaustive) that
generates a single case and triggers a new completion at the case word,
for editors that support
CompletionItem.command.