bugfix: Don't start mtags with full classpath #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was done by mistake in scalameta#2417 but very rarely caused any issues. Previous to that PR we would only get Scala jars from ScalaBuildTarget.getJars method and after we would use the full classpath. This never happened in the latest Scala version as we would just start mtags via new ScalaPresentationCompiler and it would happen randomly for some other versions. Now, since we always use mtags artifacts they always contain the needed Scala jars (unless there would be a custom platform) so there is no need to add anything more. This might have caused scalameta#5272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was done by mistake in #2417 but very rarely caused any issues.
Previous to that PR we would only get Scala jars from ScalaBuildTarget.getJars method and after we would use the full classpath.
This never happened in the latest Scala version as we would just start mtags via new ScalaPresentationCompiler and it would happen randomly for some other versions.
Now, since we always use mtags artifacts they always contain the needed Scala jars (unless there would be a custom platform) so there is no need to add anything more.
This might have caused #5272