New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better hint in the doctor for Maven workspaces #744
Add better hint in the doctor for Maven workspaces #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this!
72cd0dc
to
84e996e
Compare
@olafurpg I added a new section about maven, let me know if there is anything to change. Should we add similar sections for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new page for Maven is a great idea! We should probably do the same for Gradle and Mill.
We should also update the build tools tables as was done in #742. The "installation" column for Maven should be something like ✔️ instead of ✅ with an explanation below "✔️ Requires manual changes to the build to enable 'Find symbol references'"
ff14036
to
111abcb
Compare
I added another column and switched the green check marks to be fully working features, while white one to be partly working. Green seems to me to show more positive sentiment. What do you think? Also fixed the maven part, it's much simpler now, thanks! I will add gradle and mill pages tomorrow. |
111abcb
to
ec05c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments on the Maven page, will review gradle and mill separately
ff64a38
to
5125f50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Only a few minor comments.
5125f50
to
2da00bd
Compare
…s, which would not help. Now we include a link to the new documentation page about maven. We also added additional gradle and mill documentation.
d7ccff6
to
7eab01d
Compare
Previously we recommended rerunning another import for maven workspaces, which would not help. Now we include a link to the full documentation
We will need to add a full documentation during the release - will take care of it.