Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better hint in the doctor for Maven workspaces #744

Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 6, 2019

Previously we recommended rerunning another import for maven workspaces, which would not help. Now we include a link to the full documentation

We will need to add a full documentation during the release - will take care of it.

image

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch 2 times, most recently from 72cd0dc to 84e996e Compare June 6, 2019 16:07
@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 6, 2019

@olafurpg I added a new section about maven, let me know if there is anything to change.

Should we add similar sections for gradle and mill ?

@tgodzik tgodzik requested a review from olafurpg June 6, 2019 16:08
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new page for Maven is a great idea! We should probably do the same for Gradle and Mill.

We should also update the build tools tables as was done in #742. The "installation" column for Maven should be something like ✔️ instead of ✅ with an explanation below "✔️ Requires manual changes to the build to enable 'Find symbol references'"

docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch 2 times, most recently from ff14036 to 111abcb Compare June 6, 2019 17:13
@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 6, 2019

Adding a new page for Maven is a great idea! We should probably do the same for Gradle and Mill.

We should also update the build tools tables as was done in #742. The "installation" column for Maven should be something like instead of with an explanation below " Requires manual changes to the build to enable 'Find symbol references'"

I added another column and switched the green check marks to be fully working features, while white one to be partly working. Green seems to me to show more positive sentiment. What do you think?

Also fixed the maven part, it's much simpler now, thanks! I will add gradle and mill pages tomorrow.

@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch from 111abcb to ec05c77 Compare June 7, 2019 10:54
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on the Maven page, will review gradle and mill separately

docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
docs/build-tools/maven.md Outdated Show resolved Hide resolved
@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch 3 times, most recently from ff64a38 to 5125f50 Compare June 7, 2019 12:34
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Only a few minor comments.

docs/build-tools/mill.md Outdated Show resolved Hide resolved
docs/build-tools/mill.md Outdated Show resolved Hide resolved
docs/build-tools/gradle.md Outdated Show resolved Hide resolved
docs/build-tools/gradle.md Outdated Show resolved Hide resolved
docs/build-tools/gradle.md Outdated Show resolved Hide resolved
@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch from 5125f50 to 2da00bd Compare June 7, 2019 13:32
…s, which would not help. Now we include a link to the new documentation page about maven. We also added additional gradle and mill documentation.
@tgodzik tgodzik force-pushed the add-better-hint-for-maven-workspaces branch from d7ccff6 to 7eab01d Compare June 7, 2019 14:18
@tgodzik tgodzik merged commit ff60ef0 into scalameta:master Jun 7, 2019
@tgodzik tgodzik deleted the add-better-hint-for-maven-workspaces branch June 7, 2019 15:05
@tgodzik tgodzik added this to the Metals v0.6 - Radium milestone Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants