Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with wrong deprecation warning for 2.11 and update snapshot version #804

Merged
merged 1 commit into from Jun 28, 2019
Merged

Fix an issue with wrong deprecation warning for 2.11 and update snapshot version #804

merged 1 commit into from Jun 28, 2019

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 28, 2019 •
edited

image

Added might in order not to scare 2.11 people too much.

@tgodzik tgodzik requested a review from gabro June 28, 2019 17:24
gabro
gabro approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix!

@tgodzik tgodzik merged commit ad050da into scalameta:master Jun 28, 2019
@tgodzik tgodzik deleted the fix-deprecation branch June 28, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabro gabro gabro approved these changes

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @gabro @olafurpg