Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more possible presentation compiler classpath issues #901

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Sep 5, 2019

Found two issues with how we create presentation compiler:

  • we don't check if semanticDB version in scalac options is a correct one
  • when downloading dependencies for PC we don't make sure correct Scala compiler version is downloaded

This should fix both.

@tgodzik tgodzik requested review from olafurpg and gabro Sep 5, 2019
…ly correct scalameta version
@tgodzik tgodzik force-pushed the tgodzik:fix-more-pc branch from 445d7f3 to 0b10587 Sep 5, 2019
Copy link
Member

left a comment

LGTM apart from a minor suggestion

Copy link
Member

left a comment

Thank you for looking into this!

Co-Authored-By: Gabriele Petronella <gabriele@buildo.io>
@gabro
gabro approved these changes Sep 5, 2019
@tgodzik tgodzik merged commit 2f01f87 into scalameta:master Sep 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190905.8 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:fix-more-pc branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.