Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more possible presentation compiler classpath issues #901

Merged
merged 2 commits into from Sep 5, 2019
Merged

Fix more possible presentation compiler classpath issues #901

merged 2 commits into from Sep 5, 2019

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 5, 2019

Found two issues with how we create presentation compiler:

  • we don't check if semanticDB version in scalac options is a correct one
  • when downloading dependencies for PC we don't make sure correct Scala compiler version is downloaded

This should fix both.

gabro
gabro requested changes Sep 5, 2019
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor suggestion

metals/src/main/scala/scala/meta/internal/metals/Embedded.scala Outdated Show resolved Hide resolved
olafurpg
olafurpg approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!

@tgodzik @gabro
Update metals/src/main/scala/scala/meta/internal/metals/Embedded.scala
49c5583 
Co-Authored-By: Gabriele Petronella <gabriele@buildo.io>
@tgodzik tgodzik merged commit 2f01f87 into scalameta:master Sep 5, 2019
@tgodzik tgodzik deleted the fix-more-pc branch September 5, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabro gabro gabro approved these changes

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @gabro @olafurpg