Fix unitToProp implicit conversion
#449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assumed binary-compatibility is not a concern because of the 1.0 bump. But, if it is a concern, happy to implement this in a binary-compatible way. |
|
(About bincompat, I agree it's fine to publish it against 1.0) |
|
Do you need me to add a MiMa exclusion for CI? |
|
Not sure, @olafurpg wdty? |
|
We should add binary exclusions in build.sbt so that it’s easier to document what breaking changes are for v1 |
|
I've restarted the build which had a spurious failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes up in compiler warnings on Scala 3, which will no longer support
implicitconversions defined as implicit functions (instead of methods).