MUnitRunner: avoid invoking fireTestStarted if a test is skipped. #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @valencik and @armanbilge since it appears you are the most active contributors lately |
marcphilipp
approved these changes
Nov 10, 2022
tgodzik
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves down
notifier.fireTestStarted(description)to only apply when a test is NOT ignored. This will not also follow theorg.junit.runner.notification.RunNotifiercontract but also unblock people in Gradle to use their enterprise featuresI wonder if this could be added to a potential v1.0.0-M7
Here is a build scan that shows the tests working now in Gradle with this change https://scans.gradle.com/s/t2og6zyoc3nzc/tests/overview