improvement: Remove scalacheck so that base munit doesn't depend on scalacheck #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
remove-scalacheck
branch
from
87df671
to
6014c07
Compare
valencik
approved these changes
Apr 17, 2024
| .enablePlugins(MdocPlugin, DocusaurusPlugin) | ||
| .disablePlugins(MimaPlugin) | ||
| .settings( | ||
| sharedSettings, | ||
| publish / skip := true, | ||
| moduleName := "munit-docs", | ||
| libraryDependencies += "org.scalameta" %% "munit-scalacheck" % "1.0.0-M11", |
There was a problem hiding this comment.
What do we need this for in the docs? Should any doc examples move to the munit-scalacheck module too?
There was a problem hiding this comment.
It's for https://scalameta.org/munit/docs/integrations/scalacheck.html we compile the snippets there which is why we need the dependency. We could move to a separate page, but that would be a single page, so I thought it's not worth it yet.
…calacheck This causes us to be blocked whenever scalacheck needs to update still or when scalacheck moves to a newer LTS while we haven't (it's the case now)
tgodzik
force-pushed
the
remove-scalacheck
branch
from
6014c07
to
6d841f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes us to be blocked whenever scalacheck needs to update still or when scalacheck moves to a newer LTS while we haven't (it's the case now)
Fixes #758
Moved it here https://github.com/scalameta/munit-scalacheck
CC @olafurpg @gabro