Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align output for ignored and skipped tests between all 3 platforms #766

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

mzuehlke
Copy link
Contributor

This aligns the out of ignore and skipped assume(false)test on all 3 platforms.

munit.SkippedFrameworkSuite:
  + pass <elapsed time>
==> i ignore ignored
  + assume(true) <elapsed time>
==> s assume(false) skipped

I added tests for the behavior of the verbose and the default mode on the JVM and on JS + Native (there are still small differences).

The first commit in this PR just introduces the test with the prior behavior.
The 2nd commit introduces the change.

Fixes #549

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit dac6d06 into scalameta:main Apr 18, 2024
9 checks passed
@mzuehlke mzuehlke deleted the reporting branch April 19, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignored tests doesn't produce output on Scala.js
2 participants