Update readme #35
Merged
Update readme #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When app or its dependency use JNI, running native image fails if `nativeImageOptions += s"-H:ConfigurationFileDirectories=${target.value / "native-image-configs" }"` is not set or nativeImageRunAgent is not executed.
update version
olafurpg
requested changes
Oct 13, 2021
There was a problem hiding this comment.
Can we add these changes to the dedicated nativeImageRunAgent section? https://github.com/scalameta/sbt-native-image#nativeimagerunagent
The "Getting Started" section should focus on the most common case. Users are prone to blindly copy-paste the code from the getting started example assuming they need all of the features.
|
@olafurpg Sorry for late reply.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When app or its dependency use JNI, running native image fails if
nativeImageOptions += s"-H:ConfigurationFileDirectories=${target.value / "native-image-configs" }"is not set or nativeImageRunAgent is not executed.